add 'fields' parameter in doc level query object. #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirsep
requested review from
lezzago,
qreshi,
bowenlan-amzn,
rishabhmaurya,
getsaurabh02,
sbcd90 and
AWSHurneyt
as code owners
Signed-off-by: Surya Sashank Nistala <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #546 +/- ##
============================================
- Coverage 74.64% 74.55% -0.09%
Complexity 872 872
============================================
Files 130 130
Lines 5667 5680 +13
Branches 697 698 +1
============================================
+ Hits 4230 4235 +5
- Misses 1130 1139 +9
+ Partials 307 306 -1
|
AWSHurneyt
approved these changes
Oct 7, 2023
sbcd90
approved these changes
Oct 7, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 14, 2023
Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 2ef47f9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 14, 2023
Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 2ef47f9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Oct 14, 2023
eirsep
pushed a commit
that referenced
this pull request
Oct 19, 2023
(cherry picked from commit 2ef47f9) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep
pushed a commit
that referenced
this pull request
Oct 19, 2023
(cherry picked from commit 2ef47f9) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep
added a commit
to eirsep/common-utils
that referenced
this pull request
Nov 27, 2023
eirsep
added a commit
to eirsep/common-utils
that referenced
this pull request
Nov 27, 2023
…-project#546) (opensearch-project#551)" This reverts commit d92419d. Signed-off-by: Surya Sashank Nistala <[email protected]>
eirsep
added a commit
that referenced
this pull request
Nov 27, 2023
* Revert "add fields param in toxcontent() for doc level query (#549) (#555)" This reverts commit dcf288d. Signed-off-by: Surya Sashank Nistala <[email protected]> * Revert "add 'fields' parameter in doc level query object. (#546) (#551)" This reverts commit d92419d. Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Apr 12, 2024
…#546) (opensearch-project#550) (cherry picked from commit 2ef47f9) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Query string query supports fields parameter in percolate queries.
https://opensearch.org/docs/latest/query-dsl/full-text/query-string/#parameters
to support queries with multiple fields or wildcards in percolate query.
This enabled queries like
Issues Resolved
[BUG] Unable to create doc level monitor when passing wildcard field names in query string query